Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garbage collector support #26

Open
cspotcode opened this issue Jun 15, 2023 · 1 comment
Open

Garbage collector support #26

cspotcode opened this issue Jun 15, 2023 · 1 comment

Comments

@cspotcode
Copy link
Collaborator

cspotcode commented Jun 15, 2023

We must implement explicit support for cpython's garbage collector, otherwise we'll have memory leaks.

https://pyo3.rs/v0.19.0/class/protocols.html?highlight=garbage%20collector#garbage-collector-integration

See this thread where I shared a reproduction which proves we currently have a memory leak:
https://discord.com/channels/458662222697070613/1085299745116917851/1118689518321684541

@Cleptomania
Copy link
Member

I'm gonna leave this open because it's probably relevant for future stuff, but as of the 1.0.0 release and stripping out the Sprite stuff which will need to be re-implemented, we don't have anything that this effects, however we definitely will so I'm gonna leave this open as a reminder that we need to do this when the time comes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants