-
-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup mypy type checking in CI #1278
Comments
Hi guys, I'm interested to do this task! 😄 |
Hi @kenjihiraoka thanks for your interest on working on this issue :) I can assign it to you and you can start working on that. As the issue may be large, feel free to submit several PRs. PS: Notes for Hacktoferfest
|
@vfdev-5 so the ideia is to add the mypy check inside of |
@kenjihiraoka that's right.
Let's see which files are directly passing and ignore for others. |
@kenjihiraoka Can I close this issue ? |
Currently, mypy ignores all errors for all modules. We have to rework our typing such that mypy checks the code. |
🚀 Feature
Idea is to setup type checking of the codebase with mypy with our Travis CI (here) :
At the first iteration we can ignore most of the errors with
mypy.ini
. Example of mypy.ini. => done Setup Mypy check at CI step #1296For other iterations, let's set
ignore_errors = False
for a module (e.g.[mypy-ignite.utils.*]
) (see mypy.ini) and fix mypy errors.For Hacktoberfest contributors, feel free to ask questions for details if any and say that you would like to tackle the issue.
Please, take a look at CONTRIBUTING guide.
The text was updated successfully, but these errors were encountered: