Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup mypy type checking in CI #1278

Closed
vfdev-5 opened this issue Sep 10, 2020 · 6 comments
Closed

Setup mypy type checking in CI #1278

vfdev-5 opened this issue Sep 10, 2020 · 6 comments

Comments

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Sep 10, 2020

🚀 Feature

Idea is to setup type checking of the codebase with mypy with our Travis CI (here) :

mypy --config-file mypy.ini
  • At the first iteration we can ignore most of the errors with mypy.ini. Example of mypy.ini. => done Setup Mypy check at CI step #1296

  • For other iterations, let's set ignore_errors = False for a module (e.g. [mypy-ignite.utils.*]) (see mypy.ini) and fix mypy errors.

For Hacktoberfest contributors, feel free to ask questions for details if any and say that you would like to tackle the issue.
Please, take a look at CONTRIBUTING guide.

@kenjihiraoka
Copy link
Contributor

Hi guys, I'm interested to do this task! 😄

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Sep 14, 2020

Hi @kenjihiraoka thanks for your interest on working on this issue :)

I can assign it to you and you can start working on that. As the issue may be large, feel free to submit several PRs.

PS: Notes for Hacktoferfest

September is Preptember – a full month for maintainers to groom your repositories and for contributors to learn about making quality pull requests.

Contributions during September don't count toward Hacktoberfest. Only pull requests submitted between October 1st to 31st will count.

@kenjihiraoka
Copy link
Contributor

kenjihiraoka commented Sep 15, 2020

@vfdev-5 so the ideia is to add the mypy check inside of Lint check stage, right? Or I create a new one just for Mypy?
And by now, can I skip all errors?

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Sep 15, 2020

so the ideia is to add the mypy check inside of Lint check stage, right?

@kenjihiraoka that's right.

And by now, can I skip all errors?

Let's see which files are directly passing and ignore for others.

@sdesrozis
Copy link
Contributor

@kenjihiraoka Can I close this issue ?

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Oct 2, 2020

Currently, mypy ignores all errors for all modules. We have to rework our typing such that mypy checks the code.
We can close this issue and create another one to make mypy pass on some of ignite's core modules like utils etc

@vfdev-5 vfdev-5 closed this as completed Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants