Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy issue with pytorch nightly #1446

Closed
vfdev-5 opened this issue Nov 9, 2020 · 3 comments · Fixed by #1447
Closed

Fix mypy issue with pytorch nightly #1446

vfdev-5 opened this issue Nov 9, 2020 · 3 comments · Fixed by #1447
Labels

Comments

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Nov 9, 2020

🐛 Bug description

Currently, there is an issue with running mypy on ignite when using pytorch-nightly :

 ignite/distributed/comp_models/native.py:334: error: Incompatible types in
assignment (expression has type "ReduceOp", variable has type "str") 
[assignment]
                op = self._reduce_op_map[op]
                     ^
Found 1 error in 1 file (checked 84 source files)

https://github.com/pytorch/ignite/runs/1373059337#step:5:17

@gruebel could you please take a look if we can fix it ? Thanks

@vfdev-5 vfdev-5 added the bug label Nov 9, 2020
@gruebel
Copy link
Contributor

gruebel commented Nov 9, 2020

Sure, I can take a look today

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Nov 9, 2020

Thanks @gruebel ! And couldy you please also remove namedtuple import (#1433 (comment)). I merged too fast that PR :)

@gruebel
Copy link
Contributor

gruebel commented Nov 9, 2020

yeah, good point. Already forgot about it 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants