Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Make it clear in CONTRIBUTION.MD that distributed tests should be skipped on windows #1619

Closed
ahmedo42 opened this issue Feb 6, 2021 · 2 comments · Fixed by #1620
Closed

[docs] Make it clear in CONTRIBUTION.MD that distributed tests should be skipped on windows #1619

ahmedo42 opened this issue Feb 6, 2021 · 2 comments · Fixed by #1620
Labels
docs enhancement

Comments

@ahmedo42
Copy link
Contributor

ahmedo42 commented Feb 6, 2021

🚀 Feature

While running tests on windows I realized that the terminal freezes upon running distributed tests , until I found #1426 .
should this be made clear in the docs ?
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Feb 6, 2021

@ahmedo42 thanks ! Yes, it would be nice to mention that !

Btw, if you are on Windows, would you be interested in working on this issue : #1432
This could enable ignite distributed automatic setup and those tests, I think.

@ahmedo42
Copy link
Contributor Author

ahmedo42 commented Feb 6, 2021

I'll make a PR
regarding #1432 , I'm interested in making it work but I'll have to do some digging first , I'll let you know if I'm going to take it.

@ahmedo42 ahmedo42 mentioned this issue Feb 6, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Distributed tests on Windows should be skipped until fixed. ahmedo42/ignite
2 participants
@vfdev-5 @ahmedo42