Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce an handler to use new profiler #1917

Open
sdesrozis opened this issue Apr 8, 2021 · 7 comments · May be fixed by #2315 or #2906
Open

Introduce an handler to use new profiler #1917

sdesrozis opened this issue Apr 8, 2021 · 7 comments · May be fixed by #2315 or #2906
Labels
enhancement Hacktoberfest help wanted PyDataGlobal PyData Global 2020 Sprint

Comments

@sdesrozis
Copy link
Contributor

sdesrozis commented Apr 8, 2021 •
edited
Loading

🚀 Feature

As discussed in #1916, a new profiler tool was recently introduced and it would be nice to have a specific handler in ignite.
@ydcjeff
Copy link
Contributor

ydcjeff commented Apr 11, 2021

question: should this handler live in core module or contrib module?

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Apr 11, 2021

I think in future we'll merge contrib into core. Let's already put it into core.

@vfdev-5 vfdev-5 added the PyDataGlobal PyData Global 2020 Sprint label Oct 21, 2021
@Ishan-Kumar2
Copy link
Contributor

Hi @sdesrozis and @vfdev-5, I am interested in this.

@sdesrozis
Copy link
Contributor Author

Hi @sdesrozis and @vfdev-5, I am interested in this.

Great !

@Ishan-Kumar2 Ishan-Kumar2 linked a pull request Nov 9, 2021 that will close this issue
Open
3 tasks
@apupneja
Copy link

apupneja commented Feb 5, 2023

I would like to try and solve this issue @vfdev-5. Let me know if there's something in particular that you believe needs to be fixed from #2315. If not, I would be going through it, and re-implement it.

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Feb 6, 2023

@apupneja Existing PR can give an example. It may need some refreshing but can definitely serve as a backbone for a new one

@guptaaryan16
Copy link
Contributor

Hey @vfdev-5 , I would like to take up this issue now
cc @sdesrozis

@guptaaryan16 guptaaryan16 linked a pull request Apr 1, 2023 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Hacktoberfest help wanted PyDataGlobal PyData Global 2020 Sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] added PyTorch Profiler Ishan-Kumar2/ignite
PyTorch Profiler [WIP] guptaaryan16/ignite
6 participants
@vfdev-5 @sdesrozis @ydcjeff @Ishan-Kumar2 @apupneja @guptaaryan16