Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Decouple profiler profile_freq from memory snapshot frequency #475

Open
awgu opened this issue Jul 23, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@awgu
Copy link
Contributor

awgu commented Jul 23, 2024

For memory snapshot, we usually only need to take a snapshot on one of the first few iterations (e.g. step 2 or 3) after the optimizer step has run on step 1. We do not need to repeatedly take snapshots. We cannot do this easily since the memory profiler uses the same profile_freq as the trace profiler.

@tianyu-l tianyu-l added the enhancement New feature or request label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants