-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to use functions with param dependencies in DynamicMap #3744
Conversation
Code looks fine but I'm starting to lose track of all the ways you can do things with param watchers, panel etc. I assume the alternative would be a class which is unnecessary for such a simple example? I guess I am happy to merge but I would also like to see some docs detailing this style among all the other ways you can do things with param nowadays. |
That is on my to-do list along with |
67100ab
to
1c7fdd5
Compare
@philippjfr Looks good! My comments generally relate to expanding the docs in a few places. There is one question about reordering the presentation of the function/class approach but I have no opinion as to whether that should be part of this PR or not. Another task that shouldn't be part of this PR is to expand the streams user guide to discuss these implicit parameter streams. There are now three types of stream in holoviews imho 1) explicitly defined custom stream objects and classes 2) linked streams 3) implicit parameter driven ones. Happy to merge once these doc issues are addressed (or postponed for later PRs). And once the tests are passing! |
Co-Authored-By: Philipp Rudiger <[email protected]>
03f3174
to
1051f14
Compare
Co-Authored-By: James A. Bednar <[email protected]>
Looks good now, thanks! |
Co-Authored-By: James A. Bednar <[email protected]>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Allows doing things like: