Fix GridSpace and GridMatrix sort=False

[poplarShift]

Fixes #3462

Previously, sorted(set(...)) implicitly sorted grid keys, now passing sort=False has the intended effect:

import numpy as np
import holoviews as hv
hv.extension('matplotlib')

data = hv.Image(np.random.rand(10,10))
imgs = [
    (('C', 'dummy'), data),
    (('D', 'dummy'), data),
    (('A', 'dummy'), data),
    (('B', 'dummy'), data)
]
hv.GridSpace(imgs, sort=False, kdims=['dim1','dim2'])

#3770 is vaguely related (this PR highlights some code duplication) in the (non-) sorting of dimension values.

[philippjfr]

There does seem to be a real failure in the Python 2 tests. Presumably something to do with dict ordering? Can't wait to drop py2 support.

[poplarShift]

Great,

print(sorted(set(('c', 'b'))))
print(list(dict.fromkeys(('c', 'b'))))

print(sorted(set(('b', 'c'))))
print(list(dict.fromkeys(('b', 'c'))))

Yields

['b', 'c']
['c', 'b']
['b', 'c']
['b', 'c']

in python 3

but

['b', 'c']
['c', 'b']
['b', 'c']
['c', 'b']

in python 2!

[poplarShift]

So, that should do the trick I hope...

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.