Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Histogram color cycle #1008

Merged
merged 1 commit into from
Dec 10, 2016
Merged

Define Histogram color cycle #1008

merged 1 commit into from
Dec 10, 2016

Conversation

philippjfr
Copy link
Member

As suggested in #918, bokeh Histograms should have the same color cycle as the matplotlib version defined.

Before the PR:

bokeh_plot 20

With the PR:

bokeh_plot 19

@philippjfr
Copy link
Member Author

philippjfr commented Dec 10, 2016

Would you look at that Travis reporting the exact change in the bokeh data:

{'values_changed': {u"root['roots']['references'][38]['attributes']['fill_color']['value']": {'new_value': u'#036564', 'old_value': u'#30a2da'}}

Tests will have to be updated.

@jlstevens
Copy link
Contributor

Looks good and I am happy to merge once the tests are updated and passing.

@philippjfr
Copy link
Member Author

philippjfr commented Dec 10, 2016

Tests regenerated and push builds passed. Ready to merge.

@jlstevens jlstevens merged commit 25ff7d1 into master Dec 10, 2016
@philippjfr philippjfr deleted the bokeh_histogram_color branch December 10, 2016 23:42
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants