-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define Dimension formatters for numpy integer types #1009
Conversation
Looks good and I a happy to merge once the tests are passing. The only suggestion I have is to investigate whether there is an easy way to iterate over all numpy integer types - if so, iterating over them would be better than having to list them all explicitly this way. |
As long as we are treating them all as separate types I prefer to be explicit about it. I do think that rather than specifying it by an actual type it might be more useful to declare that all integer types should respect the formatter. May we should consider whether |
Apparently this has resulted in small changes in the bokeh table tests. Will update. |
@jlstevens Any opinions on my comment above? |
I think I agree that this makes sense.
Sounds reasonable for scalars...I assume the formatters won't do a good job for arbitrary arrays. Edit: Note that I am happy to merge if you want to tackle these other ideas later. |
ffb9715
to
b4032e4
Compare
b8aa93a
to
c20a253
Compare
c20a253
to
3ef3c4a
Compare
Let's go with this for now. Rebuilding test data shortly. |
The pr build passed. Merging. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
As described in #975, widgets do not correctly format integers at the moment. This is easily fixed by defining
Dimension.type_formatters
for the numpy integer types.