Temporary fix for RasterGridPlot #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
force-pushed
the
raster_grid_fix
branch
from
46b8324
to
5140a3f
Compare
|
Not sure why the tests didn't fail here but the broken plot in Exploring_Data seems to be working now. Edit: The tests don't display widgets which is what triggered this issue. So it makes sense. |
philippjfr
added
type: bug
|
@jlstevens Ready to merge, just a very tiny stub for the time being. |
Please do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #976 RasterGridPlot currently fails because it has no streams attribute. This is because it's a very atypical plot type that does not currently support streams, making streams and comms work with it will be some effort. Once this has been merged we should open an issue to add that support.