Fixed python widget key precision to match JS #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
force-pushed
the
widget_precision
branch
2 times, most recently
from
8c90edc
to
34b8076
Compare
|
May have to rebuild tests but this is now behaving correctly. |
|
Happy to merge once the tests pass. I hope we will one day be able to test this properly - maybe using selenium? :-) |
philippjfr
force-pushed
the
widget_precision
branch
from
34b8076
to
d42e139
Compare
|
Yes, we'll definitely want to add selenium tests at some point. I'd like to add some to test bokeh stream events before releasing 1.7. |
That would be a very good idea. Anyway, tests have passed so I will now merge. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is pretty strange, as revealed in #1052, it turns out the precision the widget keys are set to in Python does not match the precision specified by the widgets. It seems I changed the value as part of a fix for DynamicMap. Will have to investigate what that was about before merging this.