Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dynamic dimension values #1103

Merged
merged 2 commits into from
Feb 6, 2017
Merged

Merge dynamic dimension values #1103

merged 2 commits into from
Feb 6, 2017

Conversation

philippjfr
Copy link
Member

Merges the values from multiple composed DynamicMaps addressing #920.

"""
Merges lists of fully or partially overlapping dimensions by
combining their values.
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is clear enough, but it might be nice to add a doctest example here (if we are using doctests).

@jlstevens
Copy link
Contributor

Looks like my comment in the issue regarding a KeyError was confused. Anyway, merging dimensions with merge_dimensions makes sense - my only question, is there anywhere else we should be using it?

@philippjfr
Copy link
Member Author

philippjfr commented Feb 6, 2017

my only question, is there anywhere else we should be using it?

I think this uses it everywhere it matters, i.e. when merging HoloMaps/DynamicMaps in an Overlay and when computing the dimensions during plotting to handle Layouts/GridSpaces of multiple HoloMaps/DynamicMaps

@jlstevens
Copy link
Contributor

Thanks for adding the doctest!

Happy to merge once the tests pass.

@philippjfr
Copy link
Member Author

Some syntax error due to the test being multi-line.

@philippjfr
Copy link
Member Author

Ready to merge when it passes.

@philippjfr philippjfr added this to the v1.7.0 milestone Feb 6, 2017
@jlstevens
Copy link
Contributor

Tests have passed. Merging.

@jlstevens jlstevens merged commit b38c518 into master Feb 6, 2017
@philippjfr philippjfr deleted the merge_dimension_values branch February 10, 2017 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants