Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly import top-level util module #1164

Merged
merged 1 commit into from
Feb 28, 2017
Merged

Correctly import top-level util module #1164

merged 1 commit into from
Feb 28, 2017

Conversation

philippjfr
Copy link
Member

Fixes #1134

@jlstevens
Copy link
Contributor

Glad this is fixed, but can you explain it to me?

@philippjfr
Copy link
Member Author

philippjfr commented Feb 28, 2017

Honestly, I can't. Apparently a module has to exported with an explicit import and since we have from __future__ import absolute_imports enabled and:

import .util

isn't valid syntax, this was the only thing left to try and it seems to work.

@jlstevens
Copy link
Contributor

Whatever it was, glad it is fixed! Merging.

@jlstevens jlstevens merged commit 451d4e1 into master Feb 28, 2017
@philippjfr philippjfr deleted the top_level_util branch April 11, 2017 12:30
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants