Added BokehRenderer.app method to create bokeh apps in scripts and notebooks #1283
Conversation
|
Great! All it needs is an example script in |
I'll just change the existing examples to use this. |
Makes sense. |
|
Updated the examples, ready to merge once tests pass. |
| @@ -33,6 +33,9 @@ | |||
|
|
|||
| Store.renderers['bokeh'] = BokehRenderer.instance() | |||
|
|
|||
| if len(Store.renderers) == 1: | |||
There was a problem hiding this comment.
Why not check that the one available renderer is 'bokeh'?
There was a problem hiding this comment.
Guess I could but defining that renderer is literally the line above so it has to be bokeh.
There was a problem hiding this comment.
Is your suggestion this?
if list(Store.renderers.keys()) == ['bokeh']
There was a problem hiding this comment.
You last post appeared before my reply. Either way is fine.
There was a problem hiding this comment.
In that case, I would mention that in a script-level docstring at the top of the file. Same for the crossfilter app. It only needs to be one line explaining what these examples are supposed to show.
|
Thanks for fixing the |
|
Yes, player does not use BokehRenderer.app it's an example of creating a custom bokeh layout with custom widgets. |
|
Looks good. Merging. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Adds convenience method to create bokeh Apps from any holoviews object. In a script it simply returns the
docbut when used with notebook option creates anApplicationinstance which is displayed and returned.