Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed py3 bug on Renderer.export_widgets #1289

Merged
merged 1 commit into from
Apr 13, 2017
Merged

Fixed py3 bug on Renderer.export_widgets #1289

merged 1 commit into from
Apr 13, 2017

Conversation

philippjfr
Copy link
Member

Renderer.export_widgets wasn't correctly declaring it was writing bytes.

Fixes #1234

@philippjfr philippjfr added the type: bug Something isn't correct or isn't working label Apr 13, 2017
@jlstevens
Copy link
Contributor

Great you found it!

@philippjfr
Copy link
Member Author

Also messed with the options on a subsequent plot, rebuilding the test data.

@philippjfr
Copy link
Member Author

Ready to merge.

@jlstevens
Copy link
Contributor

Merging.

@jlstevens jlstevens merged commit 20b1e19 into master Apr 13, 2017
@philippjfr philippjfr deleted the renderer_export_widgets_fix branch April 19, 2017 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippjfr @jlstevens