Fixed bug in sorting on array interface #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
type: bug
|
Ready to review. Note that the grid interfaces don't support sorting in general and neither does dask, hence the "Not supported" unit tests. |
|
Using a record array like that seems a bit like a big hammer but I can see why it might be more reliable. Anyway, looks good and the tests are passing. Merging. |
Since it's just a view it should be fairly lightweight, and looking back at it I think it was using a record array without explicit naming before anyway. Seems to be the only way to sort by column. |
|
For lexical sort? Right, I've used record arrays for that before... |
Right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that sorting on the ArrayInterface was broken in certain cases, this creates a recarray view to perform the sorting on, which should work more robustly. I'll add a couple of tests before this is ready to merge.