-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for static bokeh png rendering #1493
Conversation
Happy to merge this simple addition. My only worry is we need to keep testing it to make sure it continues to work as the Bokeh export API evolves. Might be worth having a unit test that just checks that a PNG file is generated (without trying to check the contents). |
Sounds reasonable. |
I suppose getting this unit tests working means updating the bokeh version on Travis. Alternatively, we could annotate such tests like we do with 'optional' to skip them for now... |
It is marked optional, just like the other bokeh renderer tests. |
We need a new annotation as Travis runs all tests (doesn't use |
Seems easier to just add a SkipTest that checks the bokeh version for now. |
Good idea. |
There is no need to ever remove the version check for the |
300c215
to
6dbd5d0
Compare
6dbd5d0
to
76775e6
Compare
The pr builds are green so I'll merge once the push build is green as well. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The bokeh 0.12.6 release will add static png rendering support and this PR exposes this support at the bokeh renderer level. Because rendering to png is so slow this is not particularly useful for working interactively but will be very useful for generating output which can be embedded in any document, including the thumbnails for our gallery.