Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for colormapping Contours #1499

Merged
merged 3 commits into from
May 31, 2017
Merged

Add support for colormapping Contours #1499

merged 3 commits into from
May 31, 2017

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented May 31, 2017 •
edited
Loading

Turns out Contours in bokeh did not support colormapping, which I noticed as I was reworking the Contours element example. Since colormapping is handled on a baseclass this was an easy addition:

%%opts Contours (cmap='viridis')
hv.operation.contours(hv.Image(np.sin(x**2+y**2)), levels=np.linspace(0, 1, 9),
                      overlaid=False)

bokeh_plot 59

@jlstevens
Copy link
Contributor

Great! The more consistent things can be, the better.

Happy to merge when the tests pass.

@philippjfr
Copy link
Member Author

So it turns out the matplotlib version also didn't support colormapping, so Contours has never worked like it was supposed to, while Polygons has.

@philippjfr
Copy link
Member Author

Ready to merge, PR build already passed.

@jlstevens
Copy link
Contributor

Merging.

@jlstevens jlstevens merged commit 0d983ea into master May 31, 2017
@philippjfr philippjfr deleted the contours_bokeh branch June 17, 2017 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tag: backend: bokeh type: feature A major new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippjfr @jlstevens