Small fixes for computing spreadfn aggregates #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
type: bug
|
Looks like I need to rebuild test data, the Columnar_Data examples of using the spread function were using pandas and are therefore affected by the |
|
Sounds like a bad bug - glad it is fixed and I'll merge once the tests are passing again. |
|
Tests are green. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a small bug when aggregating with a spreadfn. In writing unit tests for this I also noticed that pandas uses ddof=1 (delta degrees of freedom) while the numpy default is ddof=0. I've adjusted the code to catch those cases and change the pandas version to ddof=0.