Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Empty adjoint plots in bokeh #1561

Merged
merged 1 commit into from
Jun 17, 2017
Merged

Added support for Empty adjoint plots in bokeh #1561

merged 1 commit into from
Jun 17, 2017

Conversation

philippjfr
Copy link
Member

This was already handled correctly by matplotlib but #1478 highlighted that bokeh did not handle padding for empty adjoints correctly. Also added a unit test, and here is an example:

hv.AdjointLayout([hv.Curve([0,1,1,2,3]), hv.Empty() ,hv.Curve([0,1,1,0,1])(plot=dict(height=100))])

screen shot 2017-06-17 at 2 10 35 pm

@philippjfr philippjfr added tag: backend: bokeh type: bug Something isn't correct or isn't working labels Jun 17, 2017
@jlstevens
Copy link
Contributor

Looks good. Happy to merge if it is ready and the tests turn green.

@jlstevens jlstevens merged commit e258f78 into master Jun 17, 2017
@philippjfr philippjfr deleted the empty_adjoints branch June 17, 2017 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tag: backend: bokeh type: bug Something isn't correct or isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippjfr @jlstevens