Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed Bounds to BoundsXY for consistency #1672

Merged
merged 1 commit into from
Jul 5, 2017
Merged

Conversation

jlstevens
Copy link
Contributor

PR title says everything other than the fact that Bounds still exists as an alias (with a deprecation warning).

@jlstevens jlstevens added this to the v1.8.1 milestone Jul 3, 2017
@jlstevens
Copy link
Contributor Author

@philippjfr Ready to merge if you are happy with this PR.

@philippjfr
Copy link
Member

Looks good, would be good if we could decide on what timeframe deprecations should happen and perhaps leave searchable comments marking deprecations with the release when we expect the feature to be removed. Will just merge this though.

@philippjfr philippjfr merged commit ff2cc18 into master Jul 5, 2017
@philippjfr philippjfr deleted the bounds_deprecation branch July 31, 2017 22:57
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants