-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handled bokeh log axes with axis lower bound <=0 #1691
Conversation
Should it warn? Isn't 0.01 an arbitrary value? |
Nevermind, I see you have a warning in there. |
@philippjfr Ready to merge? |
Yes. |
Looking at the current file, if I'm not mistaken it seems like the lower bound is set to 0.01 if (and not unless) the upper bound is <0.01: |
Well spotted! That is how I am reading this code as well... |
Should I file an issue on this matter? If it's just about changing the "lesser than" sign, I can make the corresponding PR as well. |
* Fix log axis lower bound when data minimum is <= 0 Set the lower bound as originally intended in #1691 * Update tests * Fix barplot Co-authored-by: Philipp Rudiger <[email protected]>
* Fix log axis lower bound when data minimum is <= 0 Set the lower bound as originally intended in #1691 * Update tests * Fix barplot Co-authored-by: Philipp Rudiger <[email protected]>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Addresses #1679. If the range lower bound is <= 0, it uses a lower bound of 0.01 unless the upper bound is <0.01, in which case it backs up to a value one decimal point lower than the upper value.