Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handled bokeh log axes with axis lower bound <=0 #1691

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Conversation

philippjfr
Copy link
Member

Addresses #1679. If the range lower bound is <= 0, it uses a lower bound of 0.01 unless the upper bound is <0.01, in which case it backs up to a value one decimal point lower than the upper value.

@jlstevens
Copy link
Contributor

Should it warn? Isn't 0.01 an arbitrary value?

@jlstevens
Copy link
Contributor

Nevermind, I see you have a warning in there.

@jlstevens
Copy link
Contributor

@philippjfr Ready to merge?

@philippjfr
Copy link
Member Author

Yes.

@TheoMathurin
Copy link
Contributor

Addresses #1679. If the range lower bound is <= 0, it uses a lower bound of 0.01 unless the upper bound is <0.01, in which case it backs up to a value one decimal point lower than the upper value.

Looking at the current file, if I'm not mistaken it seems like the lower bound is set to 0.01 if (and not unless) the upper bound is <0.01: low = 0.01 if high < 0.01 else 10**(np.log10(high)-2)

@jlstevens
Copy link
Contributor

Well spotted!

That is how I am reading this code as well...

@TheoMathurin
Copy link
Contributor

Should I file an issue on this matter?

If it's just about changing the "lesser than" sign, I can make the corresponding PR as well.

philippjfr added a commit that referenced this pull request Apr 8, 2022
* Fix log axis lower bound when data minimum is <= 0

Set the lower bound as originally intended in #1691

* Update tests

* Fix barplot

Co-authored-by: Philipp Rudiger <[email protected]>
philippjfr added a commit that referenced this pull request Apr 8, 2022
* Fix log axis lower bound when data minimum is <= 0

Set the lower bound as originally intended in #1691

* Update tests

* Fix barplot

Co-authored-by: Philipp Rudiger <[email protected]>
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants