-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for datetime axis on Image #2023
Conversation
69bf89b
to
996dd4e
Compare
Excellent!!! |
While I think Image will correctly retain timezone information, I think datashade operations will discard them. I can't say I have a strong desire to tackle that issue right now. |
Since I got to it first, I will nominate @ceball. :-) |
Needs lots of tests still of course. |
Also worth noting that it's currently using microsecond precision, switching to nanosecond precision introduces issues that are hard to handle correctly. |
When this is done, maybe open an issue about the nanosecond precision issues and say that it's not something we expect to fix, but that if someone wants to use it for that purpose then here's what they would need to fix. |
Okay, this is ready to review now. I've added a bunch of unit tests for the utilities and for the interfaces. Iris does not like datetime coordinates apparently so I've had to skip those tests. |
d41ff1d
to
2cf8f5b
Compare
This output:
changed to this:
The latter is more correct so I've updated the test data but the push build isn't pulling it for some reason. It should still work so this can be merged after review. |
I'm going to go ahead and merge this myself since other work depends on it and the best smoke test is likely using it a lot in action. @ceball promised he'd take a more in depth look even after merging. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Adds support for datetime axes on Image, SheetCoordinateSystem, BoundingBox and Slice. The basics are all working including instantiation of an Image with datetime bounds and slicing and indexing. Will make it possible to generate datashaded images with datetime axes.