Improved Graph element #2145
Merged
Improved Graph element #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
force-pushed
the
graph_enhancements
branch
3 times, most recently
from
162828a
to
d5b9651
Compare
philippjfr
force-pushed
the
graph_enhancements
branch
from
d5b9651
to
a7eeaf8
Compare
jlstevens
reviewed
Nov 23, 2017
holoviews/element/graphs.py
Outdated
| N = len(nodes) | ||
| circ = np.pi/N*np.arange(N)*2 | ||
| x = np.cos(circ) | ||
| y = np.sin(circ) | ||
| return (x, y, nodes) | ||
|
|
||
|
|
||
| def connect_edges_pd(graph): |
There was a problem hiding this comment.
Maybe move some of these functions to element.util?
jlstevens
reviewed
Nov 23, 2017
| @@ -411,6 +412,59 @@ def map_colors(arr, crange, cmap, hex=True): | |||
| return arr | |||
|
|
|||
|
|
|||
| def mplcmap_to_palette(cmap, ncolors=None): | |||
There was a problem hiding this comment.
Seems like the right place for these utilities!
jlstevens
reviewed
Nov 23, 2017
tests/testbokehgraphs.py
Outdated
| g = self.graph4.opts(plot=dict(edge_color_index='Weight'), | ||
| style=dict(edge_cmap=['#FFFFFF', '#000000'])) | ||
| plot = bokeh_renderer.get_plot(g) | ||
| print(plot.handles) |
|
Looks good! Other than some very minor comments I posted above, I am happy for you to go ahead and merge once you think it is ready. |
|
Yay, even got a gain in coverage. Thanks for the review, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I started writing the Chord (#2138) and TriMesh (#2143) elements, it's become clear that the Graph element is quite useful as a baseclass for other elements. However currently it isn't as solid, optimized and tested as I'd like it to be, so rather than mixing up a bunch of changes into the
ChordandTriMeshPRs I've decided to first build onGraph, ensuring that it is well tested and solid at it's core.This will improve Graphs in a number of ways:
Graph Element Improvements
Graph Plot improvements
GraphPlotimplementations now support anedge_color_indexallowing them to be colored both by categorical attributes (e.g. by their source node) or by a value (e.g. a weight value).