Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box whisker improvements #2187

Merged
merged 2 commits into from
Dec 11, 2017
Merged

Box whisker improvements #2187

merged 2 commits into from
Dec 11, 2017

Conversation

philippjfr
Copy link
Member

Improved BoxWhisker element docstrings as requested in #1838 and fixed hover issues as requested in #2142.

@philippjfr philippjfr added this to the v1.9.2 milestone Dec 11, 2017
representing the lowest datum still within 1.5 IQR of the lower
quartile, and the highest datum still within 1.5 IQR of the upper
quartile. Any points falling outside this range are shown as
distinct outlier points.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe 'standard Tukey boxplot definition' if it is standard? Otherwise sounds like it is just a definition for boxplots...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth expanding the name to 'John W. Tukey'...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tukey box plots is the common way to refer to this style of plot, don't think the full name adds anything.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To quote Wikipedia:

But the ends of the whiskers can represent several possible alternative values, among them:

the lowest datum still within 1.5 IQR of the lower quartile, and the highest datum still within 1.5 IQR of the upper quartile (often called the Tukey boxplot)

@jlstevens
Copy link
Contributor

One minor docstring comment. Otherwise looks good.

@jlstevens
Copy link
Contributor

Looks good. Merging.

@jlstevens jlstevens merged commit acf1c6f into master Dec 11, 2017
@philippjfr philippjfr deleted the box_whisker_improvements branch December 18, 2017 15:37
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants