Ensure Compositor does not make superfluous copies #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
tag: backend: bokeh
type: bug
|
Looks like the correct fix to me! I'll wait for the tests to pass anyhow... |
|
To clarify that I am not contradicting you, this is the right thing to do (don't touch the overlay unless the patterns apply) but it isn't the complete fix which is something we need to describe in an issue. |
|
Tests have passed. Merging. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A partial workaround/fix for #2129. The correct fix will be to ensure that a Compositor transfers the ID a stream is registered to when it is applied but since we do not ship any actual Overlay compositors by default this fix should be sufficient for 1.9.2.