Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up top-level namespace #2224

Merged
merged 2 commits into from
Nov 5, 2018
Merged

Cleaned up top-level namespace #2224

merged 2 commits into from
Nov 5, 2018

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Dec 21, 2017

As suggested in #2202 this PR cleans up the top-level namespace, removing the following items:

Element2D, Element3D, Dimensioned, AttrTree, Overlayable, StoreOptions, UniformNdMapping, ViewableElement, Overlayable, CompositeOverlay

@philippjfr
Copy link
Member Author

Pared this PR back a bit to make it mergeable in the near term, Element, NdMapping and BoundingBox are therefore still exposed.

@philippjfr
Copy link
Member Author

Here's the full list of items removed from the top level namespace:

{'AttrTree',
 'CompositeOverlay',
 'Dimensioned',
 'Element2D',
 'Element3D',
 'Overlayable',
 'Tabular',
 'UniformNdMapping',
 'ViewableElement',
 'absolute_import',
 'code',
 'elements_list',
 'f',
 'filename',
 'os',
 'print_function',
 'pydoc',
 'rcfile',
 'warnings'}

@philippjfr philippjfr added this to the v1.11.0 milestone Nov 5, 2018
@philippjfr
Copy link
Member Author

philippjfr commented Nov 5, 2018

Going to merge this, @jlstevens gave assent in the linked issue and I have undone the removal of Element that was mentioned as potentially problematic there.

@philippjfr philippjfr merged commit 2311c15 into master Nov 5, 2018
@philippjfr philippjfr deleted the cleanup_namespace branch December 13, 2018 04:22
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant