Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datetime improvements #2267

Merged
merged 4 commits into from
Jan 26, 2018
Merged

Datetime improvements #2267

merged 4 commits into from
Jan 26, 2018

Conversation

philippjfr
Copy link
Member

This PR has several related purposes:

  • datetime.datetime handled better throughout
  • datetime.date handled (addressing Add support for datetime.date #2100)
  • Use client-side formatters on bokeh tables to allow data to be shared between plots

@jlstevens
Copy link
Contributor

Looks good.

This reminds me of an issue I wanted to report where the validation for regular sampling didn't seem to work for datetimes after resampling an irregular array onto a regular basis with xarray. That sounds like a fix that might go into a PR though I'll have to come up with a simple reproducible example of the issue unless you already have an idea what I am talking about...

@philippjfr
Copy link
Member Author

This reminds me of an issue I wanted to report where the validation for regular sampling didn't seem to work for datetimes after resampling an irregular array onto a regular basis with xarray.

Please open a separate issue for that.

@jlstevens
Copy link
Contributor

Looks good. Merging.

@jlstevens jlstevens merged commit 5686696 into master Jan 26, 2018
philippjfr added a commit that referenced this pull request Feb 9, 2018
@philippjfr philippjfr added this to the 1.9.3 milestone Feb 11, 2018
@philippjfr philippjfr deleted the datetime_improvements branch February 11, 2018 17:02
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants