Handle range on heterogeneously typed Dataset column #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
type: bug
philippjfr
force-pushed
the
hetero_ds_range
branch
from
ca2382e
to
ff26b55
Compare
|
This is one semantic change in Python 3 that I find to be downright annoying. Anyway, the suggested fix makes sense. |
jlstevens
reviewed
Feb 16, 2018
holoviews/core/data/pandas.py
Outdated
| dimensions = [dataset.get_dimensions(d).name for d in dimensions] | ||
| inds = [dataset.data.columns.index(dim.name) for dim in dimensions] | ||
| return dataset.data.values[:, inds] | ||
|
|
There was a problem hiding this comment.
I don't quite see how this relates to the python 2 vs 3 sorting issue. Is this method implementating an unrelated fix?
There was a problem hiding this comment.
Yes, accidentally pushed this. Will revert.
philippjfr
force-pushed
the
hetero_ds_range
branch
2 times, most recently
from
bf5ea1b
to
92d9e35
Compare
|
Going to need rebuilt test data, but let's get #1978 merged first since that also requires new test data. |
philippjfr
force-pushed
the
hetero_ds_range
branch
from
92d9e35
to
7eeae5a
Compare
|
Happy to merge when the tests go green. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling range on a heterogeneously typed column currently causes all kinds of issues (including errors) due to python 3 sorting semantics. While range should generally not be called on object or string dtype columns it currently is so this needs to work robustly for the time being. Therefore this PR uses the python2sort utility to do the sorting robustly in python3.