Fixed bug disabling axis labels with labelled option #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
type: bug
|
@jlstevens Ready to merge. This one is pretty unfortunate and may prompt a 1.10.3 release (along with some other fixes I haven't created PRs for yet). |
|
Is this a regression or just something that wasn't properly supported when it should have been? I'm fine with a 1.10.3 release though and the changes here look good so I'll merge. |
I think it's a regression, but I think it's one that snuck in at some point in the 1.9.x series (i.e. I don't think it's not a new bug in 1.10). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
labelledplot option allows disabling axis labels, however in bokeh it is being ignored by the_update_plotmethod. This fixes the issue.