Correctly check if hover data should be added #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
type: bug
philippjfr
force-pushed
the
hover_activation_fix
branch
from
dd047aa
to
1ebaf3a
Compare
|
Very happy with this PR: it fixes the bug while making the code simpler and easier to read. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a class of bugs in the bokeh backend where the data required to display hover information for the element was added if any subplot of the overlay enabled hover information even if the hover for a particular element was not actually displayed. Rather than checking if the bokeh plot object has a HoverTool, it now checks whether the hover tool has been added to the holoviews plot handles, which is the correct way of checking whether hover was enabled.