Ignore non-referenced data in dictionary format #2859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to merge when the tests pass, though maybe it is worth adding a unit test to ensure the correct behavior? |
philippjfr
force-pushed
the
dict_non_dimensions
branch
from
50340f0
to
170e6b6
Compare
|
Alright added a unit test. |
philippjfr
force-pushed
the
dict_non_dimensions
branch
from
170e6b6
to
b6fab7d
Compare
|
Tests have just gone green. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out I hadn't correctly caught everything in #2855. This PR further ensures nothing attempts to use dictionary keys that have not been referenced as a dimension.