Add new drawing tool functionality #2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There aren't really any tests I can add here without selenium. I'd very much like to set that up soon but I think we should switch to pytest first, since that will allow us to reuse a lot of bokeh's tooling. So this is ready to review now. |
jbednar
approved these changes
Aug 11, 2018
jlstevens
reviewed
Aug 13, 2018
| "Alternatively we can use the ``element`` property to get an Element containing the returned data:" | ||
| ] | ||
| }, | ||
| { |
There was a problem hiding this comment.
Please clear out the notebook metadata...
|
Now the metadata is cleared from the new notebook, I'm happy to merge. No need to wait on tests as the last commit passed and the removal of the notebook metadata is the only change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds multiple drawing tool features I recently added to bokeh:
Adds
num_objectsoption to limit the number of glyphs that can be drawnAdds
show_verticesoption onPolyDrawenabling display of and snapping to verticesAdds new
FreehandDrawstreamTests will have to wait until we have support for Selenium