Allow using explicit colormapping on non-categorical data #3071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
tag: backend: bokeh
type: enhancement
jlstevens
reviewed
Oct 10, 2018
holoviews/plotting/bokeh/element.py
Outdated
| @@ -1189,6 +1192,11 @@ def _get_color_data(self, element, ranges, style, name='color', factors=None, co | |||
|
|
|||
| mapper = self._get_colormapper(cdim, element, ranges, style, | |||
| factors, colors) | |||
| if not factors and isinstance(mapper, CategoricalColorMapper): | |||
| field += '_str' | |||
There was a problem hiding this comment.
Does it? In what way? I've used this approach throughout.
There was a problem hiding this comment.
To be clearer, what's your suggestion for not overriding the original column and making it clear the column has been "categorized" by casting values to strings?
There was a problem hiding this comment.
It might be worth coming up with a longer string to make clashes with user columns more unlikely.
|
Looks good! I'll merge when the tests pass. |
philippjfr
force-pushed
the
explicit_categorical
branch
from
219e5be
to
52cd6fa
Compare
|
Tests have passed now. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows providing an explicit colormapping for non-categorical data.