Fixes for Polygons plotting with holes #3409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
type: bug
philippjfr
commented
Jan 17, 2019
| @@ -284,7 +284,7 @@ def range(self, dim, data_range=True, dimension_range=True): | |||
| return (None, None) | |||
| elif all(util.isfinite(v) for v in dim.range) and dimension_range: | |||
| return dim.range | |||
| elif dim in self.dimensions() and data_range and len(self): | |||
| elif dim in self.dimensions() and data_range and bool(self): | |||
There was a problem hiding this comment.
This is mainly an optimization, computing the length on a Polygons/Path can be very expensive, bool(self) is equivalent but a much quicker way to check whether the element is empty.
philippjfr
force-pushed
the
poly_fixes
branch
from
284ba4a
to
091811e
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PolygonPlot implementation switched between the MultiPolygons and Patches glyphs depending on whether the polygons have holes or not. The problem with that is that in a dynamic plot or HoloMap the returned data format may therefore change but the glyph is only initialized once, so a MultiPolygons glyph could end up with the data format for the Patches glyph and vice versa. This PR ensures that Polygons are always plotted using the MultiPolygons glyph unless a PolyDraw or PolyEdit stream is attached to the plot, which do not yet support holes. This ensures backwards compatibility while also fixing the bug.