Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas 0.24 compatibility and CI fixes #3433

Merged
merged 51 commits into from
Jan 27, 2019
Merged

Pandas 0.24 compatibility and CI fixes #3433

merged 51 commits into from
Jan 27, 2019

Conversation

philippjfr
Copy link
Member

The pandas dtype extensions changed slightly in 0.24 breaking HoloViews in major ways in the process. Apart from updating the import, to avoid this in future I've split the try/except blocks to separate the extension types and added a warning.

@jbednar
Copy link
Member

jbednar commented Jan 26, 2019

Thanks. Are there any compatibility patches you could propose for Pandas itself, to avoid such problems with other libraries?

@philippjfr
Copy link
Member Author

Are there any compatibility patches you could propose for Pandas itself, to avoid such problems with other libraries?

No, this is entirely on us (or rather me).

@philippjfr philippjfr force-pushed the pandas_0.24_compat branch 4 times, most recently from a79cc3a to 68f523d Compare January 27, 2019 18:34
@philippjfr philippjfr changed the title Pandas 0.24 compatibility Pandas 0.24 compatibility and CI fixes Jan 27, 2019
@philippjfr
Copy link
Member Author

I'm going to merge this shortly. Basically there are two remaining issues:

  • Gif and mp4 renderer tests are basically skipped in linux right now, I tried fixing this even going so far as trying to reproduce it in a linux virtual machine but had no luck.
  • Appveyor builds are currently broken (across all our projects), I've allowed them to go green despite this failure for now and filed an issue here: Miniconda permission errors appveyor/ci#2822

The PR does the following:

  • Update to all latest versions (including pandas 0.24.0, matplotlib, xarray etc.)
  • Compatibility for pandas 0.24.0
  • Add appveyor.yml (which was briefly passing until the miniconda on appveyor was updated and broken)

@philippjfr philippjfr merged commit 9b23328 into master Jan 27, 2019
@philippjfr philippjfr deleted the pandas_0.24_compat branch April 29, 2019 11:25
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants