-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colorscale/colorbar fixes for Plotly backend #3590
Conversation
This is great, thanks a lot! Subsampling the color scales sounds good to me as well, no reason to send the full palettes unlike in bokeh where interpolation is not implemented client-side. |
Not sure what's up with the tests yet, seems unrelated. |
Thanks! I'm taking a look at the tests as well. |
Ah, I know what happened, the new param release dev release changed the formatting of warnings. I'll fix that in a separate PR shortly. |
Thanks for the detective work 🙂 |
Hopefully fixed in #3591 |
plotly/plotly.js#3699. Plotly.js performs colorscale interpolation internally so reducing the number of colors here makes very little difference to the displayed colorscale.
previously an invalid colorscale was being constructed because the colorscale list of pairs was treated as if it were a list of colors
Thanks again @jonmmease. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR includes various fixes related to colorscale/colorbar handling for the plotly backend
Commit summary:
colorbar
andedges_color
handling. Both of these options are applied to separate traces (separate from the mainmesh3d
trace) which were being dropped. With these changes, anElement
may be represented by a series of traces instead of only 1.016a137
: Add/fix colorbar/colorscale handling for the plotly bivariate element. Previously, thecmap
andcolorbar
args were ignored.Elements
and the rest of them worked fine.