Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that bokeh plot refresh has the Document lock #3621

Merged
merged 2 commits into from
Apr 26, 2019

Conversation

philippjfr
Copy link
Member

Currently it is possible to get into situation where HoloViews plot classes modify the models without having the Document lock, leading to errors like this:

holoviews.core.options.AbbreviatedException: RuntimeError: _pending_writes should be non-None when we have a document lock, and we should have the lock when the document changes

@philippjfr philippjfr added type: bug Something isn't correct or isn't working tag: backend: bokeh labels Apr 12, 2019
@philippjfr philippjfr force-pushed the fix_pending_writes branch 2 times, most recently from fb74f61 to a666707 Compare April 26, 2019 14:15
@philippjfr philippjfr added this to the v1.12.2 milestone Apr 26, 2019
@philippjfr philippjfr merged commit a1213a5 into master Apr 26, 2019
@philippjfr philippjfr deleted the fix_pending_writes branch April 29, 2019 11:24
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tag: backend: bokeh type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant