Bokeh 0.11 Compatibility #393
Conversation
Allows sending just required data on notebook update
philippjfr
force-pushed
the
bokeh0.11_compat
branch
from
5007d22
to
05f2bda
Compare
| if LooseVersion(bokeh.__version__) >= LooseVersion('0.11'): | ||
| old_bokeh = False | ||
| from bokeh.io import _CommsHandle | ||
| from bokeh.util.notebook import get_comms |
There was a problem hiding this comment.
How much can we trust that _CommsHandle is something we can rely on in future? From the name, it doesn't look like something we are expected to use directly...
There was a problem hiding this comment.
Certainly possible that they will change it but there's no way around it. Bokeh notebook support is currently set up to only keep one CommsHandle open at the same so we can't rely on their core API. It's certainly worth keeping in mind though and replace it with a call to a higher-level API once/if that becomes possible.
There was a problem hiding this comment.
It's worth posting an issue on the Bokeh site asking whether this is an ok long-term solution, and/or request a better one be made available.
There was a problem hiding this comment.
I know that handling multiple Comms at once is on their radar and might even land in 0.11.1. If need be I can mirror CommsHandle in HoloViews, it's a tiny class that's just meant to hold a few attributes.
|
I've made some comments above but I'm afraid I don't know enough details to do a very thorough review. I do have one general comment though... The changes here seem to be of two types: 1. actual changes in the bokeh API to smooth over with conditional statements 2. improvements to how the code works that is compatible across both bokeh versions (i.e understanding how to leverage bokeh better). The second type of change seems general and I assume fairly stable. The first type of change is a lot of special cases and I worry that as bokeh keeps developing (and the API keeps getting tweaked) that the list of these fixes will keep growing. I'm not sure it is needed now but I might consider a class in util or even a file |
|
Agree that we'll have to add a compat.py module if there are a lot more changes to the API coming. It could simply supply various version agnostic functions to do specific things. Currently it doesn't seem worth it though. |
|
Tests are all passing so I'll merge now. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR adds various fixes to ensure HoloViews is compatible with the new 0.11 bokeh release.
It is now ready for merge.