Ensured dynamic callback is only called once #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! The PR referenced above is an example notebook that needs this fix. It is also good to have those unit tests to make sure this bug is squashed for good. I'll now review the proposed changes... |
jlstevens
reviewed
Oct 10, 2016
| @@ -967,7 +968,8 @@ def get_dynamic_item(map_obj, dimensions, key): | |||
| key_offset = max([key-map_obj.cache_size, 0]) | |||
| key = map_obj.keys()[min([key-key_offset, | |||
| len(map_obj)-1])] | |||
| el = map_obj.map(lambda x: x[key], ['DynamicMap']) | |||
| el = map_obj.map(lambda x: x[key], ['DynamicMap'], | |||
| clone=False) | |||
There was a problem hiding this comment.
Very minor nitpick: I don't see why clone=False needs to be on the next line in this case. Even if it is over 80 characters long it looks a bit weird...
jlstevens
reviewed
Oct 10, 2016
| def test_stream_callback_single_call(self): | ||
| def history_callback(x, history=deque(maxlen=10)): | ||
| history.append(x) | ||
| return Curve(list(history)) |
There was a problem hiding this comment.
Just like the price stream example notebook in contrib!
|
The actual fix is very small and the tests looks good. Happy to merge if you feel it is ready... |
|
Once the tests pass let's merge it. |
|
Tests passed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in the
get_dynamic_itemfunction ended up making clones of DynamicMaps which resulted in the dynamic callback being called multiple times. This PR fixes this and adds unit tests for all three backends to ensure the plot is appropriately updated.