Added perceptually uniform fire colormap #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! I'm just wondering if the formatting of the triples might look nicer if you aligned all the closing square brackets... |
|
Ok, reformatted as suggested. |
|
Looks good to me! For now matplotlib colormaps are used everywhere so you'll be able to reference it by name. In future we can decouple matplotlib colormaps from bokeh and switch from hot to fire in our defaults. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "hot" colormap that is the default for Image and other Raster types in Holoviews is highly perceptually nonuniform, which makes strange artifacts and makes it difficult to interpret data:
On my request, Peter Kovesi created a much better version he called linear_kryw_0_100_c71 (see http://peterkovesi.com/projects/colourmaps):
The new colormap (left) gives much smoother images that more faithfully represent the data:
This PR adds the new colormap, renamed "fire" for simplicity and to indicate the similarity to "hot". A subsequent PR should change the default colormap to "fire".