Fixed confusing aliasing #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests failed for Python3, but that seems to be unrelated to this PR, as it's a failure in a bokeh file and this is a change to the mpl backend. |
|
Looks fine, thanks for the fix. The test failure was a transient issue in the bokeh backend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attribute "colors" was being used in the same function both to refer to the matplotlib colors module and to a local dictionary. In some cases (not easily reproducible) this led to complaints about variables being referenced before they were assigned. In any case this change makes it much clearer what is meant by "colors" each time.