Counter mode deprecation #969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit tests need updating and the DynamicMap tutorial also needs to be updated. I've checked the DynamicMap tutorial works up to the point where counter mode is introduced. Seems like we'll have to update the notebook test data for this one... |
|
Going to close this as it has been superseded by #1238. |
|
I think this point is still valid:
|
|
Sure, we can discuss that in #1240, which reimplements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is work-in-progress and aims to remove the
DynamicMapcounter mode now that streams offer a much more principled way of achieving the same thing.TODO:
get_dynamic_itemand associated semantics.modeandcall_mode.call_mode='key'then the mode was'bounded'. With streams, this is not quite right: bounded should apply if any of the kdims are bounded.