Fix updateNode being called with undefined rootNode #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When redux
dispatch()
is called beforegetState()
has ever been called,updateNode()
(in the customcreatStore()
function) will be called withrootNode
still undefined.This wasn't catched in tests as they coincidentally always called
getState()
(for the cache setup) before dispatching. The added test here reproduces the bug that I was seeing when that's not the case.