Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test style to separate structure and numerical data #134

Open
lazyoracle opened this issue Aug 3, 2021 · 0 comments
Open

Update test style to separate structure and numerical data #134

lazyoracle opened this issue Aug 3, 2021 · 0 comments
Labels
code-quality General code quality related issues and PRs enhancement New feature or request

Comments

@lazyoracle
Copy link
Member

Describe the missing feature

Current tests have a coupled design where the pickle files store the structure and numerical data as a regression/historical test. This becomes difficult to maintain in the long run and also difficult to change (in the rare cases when we need to).

Describe the solution you'd like

We want to separate the structure and the numerical content and possibly also get rid of pickle files if possible. Also, we should only check the structure when it is part of the contract or API (Ref: Programming by Contract for Python)

Describe alternatives you've considered

  • Storing everything in pickle files in the same repo
  • Storing everything in pickle files in another repo
  • Storing this binary data in some cloud server (if it very rarely changes)

Additional context

Add any other context or screenshots about the feature request here. Please feel free to suggest details about how you believe this feature request might be best implemented. If you have used similar features in other libraries, consider providing links or resources to example implementations.

@lazyoracle lazyoracle added enhancement New feature or request code-quality General code quality related issues and PRs labels Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality General code quality related issues and PRs enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant