Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lbfgs_grad_free does not process iterations/function-call limits #188

Open
lazyoracle opened this issue Apr 13, 2022 · 0 comments
Open

lbfgs_grad_free does not process iterations/function-call limits #188

lazyoracle opened this issue Apr 13, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@lazyoracle
Copy link
Member

Describe the bug

From @alex-simm:

Does anyone know how to stop an optimisation that I run with lbfgs_grad_free? I have set "maxiter"=1000, "gtol"= 1e-3, but the optimiser goes way beyond that and doesn't stop.

Using maxfun as an option leads to:

No, that gives "Unknown solver options: maxfun"

To Reproduce

Steps to reproduce the behavior. This can be in the form of a code snippet or some config files or a notebook to produce a minimum viable example of the bug.

Expected behavior

A clear and concise description of what you expect(ed) to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment (please complete the following information)

  • c3-toolset Version [e.g. 1.4]

Additional context

From @nwittler:

lbfgs has a maxfun option. The code for lbfgs_grad_free however is just minimize(fun=fun, x0=x_init, options=options). According to the docs, this could result in several methods being used. Try explicitly method="L-BFGS-B" with the maxfun option.

@lazyoracle lazyoracle added the bug Something isn't working label Apr 13, 2022
@lazyoracle lazyoracle added this to the 1.5 milestone Apr 13, 2022
@lazyoracle lazyoracle self-assigned this Apr 13, 2022
@lazyoracle lazyoracle removed this from the 1.5 milestone Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant