Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoredirection based on browser language not working properly for me #307

Open
gooraloo opened this issue Nov 9, 2015 · 3 comments
Open
Labels

Comments

@gooraloo
Copy link

gooraloo commented Nov 9, 2015

I found a problem with switching language based on browser language. All options are OK, but when I want to visit site with EN language, it always redirect me to PL version. There wasn't any bugs, when I turned on debug in qtranslate_core.php
I was testing it on: jml-diving.pl
This issue is continuation from other thread: https://wordpress.org/support/topic/autoredirection-based-on-browser-language-not-working-properly-for-me?replies=2#post-7622763

@johnclause
Copy link
Member

Do you use a caching plugin? Is your problem the same as this one: #306 ?

@gooraloo
Copy link
Author

There aren't any caching plugins or other known incompatible plugins. Could you check if jml-diving.pl homepage is loading in EN language version (of course, if you have browser in EN)? Even if I switch to EN (PHP script on other website detects it as EN browser) and I visit jml-diving.pl directly, redirection not working for me...

@johnclause
Copy link
Member

Ah, I see you use per-domain url modification mode, is that correct? Initial browser detection is not applicable to that mode, since domain determines the language already uniquely, there is no ambiguity.

I am not sure what we can do. In theory, I guess, the code can be modified so that if it is per-domain, and it is default domain, and cookies are not set, then check browser language and redirect accordingly. But this would be very low priority for us. You are welcome to implement this change and to submit pull request though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants