Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel multi-core rendering glitches with OTF reprojection #19717

Closed
qgib opened this issue Oct 19, 2014 · 32 comments
Closed

Parallel multi-core rendering glitches with OTF reprojection #19717

qgib opened this issue Oct 19, 2014 · 32 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Map and Legend Related to map or legend rendering
Milestone

Comments

@qgib
Copy link
Contributor

qgib commented Oct 19, 2014

Author Name: Anita Graser (@anitagraser)
Original Redmine Issue: 11441
Affected QGIS version: master
Redmine category:map_canvas


With active on-the-fly reprojection and parallel rendering, the map renders with big artifacts. I've tested the following project with both the 2.4 release and today's nightly:

https://github.com/FOSS4GAcademy/GST101FOSS4GLabs/tree/master/Module%204%20Lab/QGIS%202.2/Lab%204%20Data

Deactivating either OTF or parallel rendering fixes the problem as far as I can tell.

!glitch.png!



Related issue(s): #19979 (relates)
Redmine related issue(s): 11746


@qgib
Copy link
Contributor Author

qgib commented Oct 19, 2014

Author Name: Giovanni Manghi (@gioman)


cannot confirm here, tested on master on both Linux and Windows (same project and data).


  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented Oct 19, 2014

Author Name: Gary Sherman (@g-sherman)


Try turning off simplification and/or "Make lines appear less jagged..." and see if it goes away. We had a similar problem years ago and I don't recall the root cause.

@qgib
Copy link
Contributor Author

qgib commented Oct 19, 2014

Author Name: Saber Razmjooei (@saberraz)


There are layers from outside the OTF CRS. According to this website: http://prj2epsg.org/epsg/5070 Canada and Mexico are outside EPSG:5070's CRS zone. I guess this causes the problem.

I have removed Mexico and Canada and the problem seems to have disappeared.

@qgib
Copy link
Contributor Author

qgib commented Oct 19, 2014

Author Name: Anita Graser (@anitagraser)


@gary: Changing the simplification settings (values, on/off) or deactivating anti-aliasing didn't change the results.

@saber: Even if I only use the US states (which should be within the CRS zone), these artifacts appear.

@qgib
Copy link
Contributor Author

qgib commented Oct 19, 2014

Author Name: Saber Razmjooei (@saberraz)


It has become less frequent. To completely get rid of the problem, I saved western_states in 5070 and used that instead. But that does not explain the source of problem.

@qgib
Copy link
Contributor Author

qgib commented Oct 20, 2014

Author Name: Martin Dobias (@wonder-sk)


I cannot replicate the problem.

@anita / @saber - which version of Proj.4 do you use? Does it happen also if you use a wgs84 for destination CRS? To my (brief) knowledge, the used epsg 5070 uses a grid file. Could you try some other projection for north america that does not involve reading of grid files? (based on parameters only)

Apparently the proj library versions < 4.8 were prone to errors when used in multi-threaded environment, but maybe we should also make use of contexts introduced in 4.8:
https://trac.osgeo.org/proj/wiki/ThreadSafety

@qgib
Copy link
Contributor Author

qgib commented Oct 20, 2014

Author Name: Giovanni Manghi (@gioman)


Martin Dobias wrote:

I cannot replicate the problem.

@anita / @saber - which version of Proj.4 do you use? Does it happen also if you use a wgs84 for destination CRS? To my (brief) knowledge, the used epsg 5070 uses a grid file. Could you try some other projection for north america that does not involve reading of grid files? (based on parameters only)

Apparently the proj library versions < 4.8 were prone to errors when used in multi-threaded environment, but maybe we should also make use of contexts introduced in 4.8:
https://trac.osgeo.org/proj/wiki/ThreadSafety

it seems anyway strange to me as I tested also on Windows (where anyone should have the same libraries) and cannot replicate the issue.

@qgib
Copy link
Contributor Author

qgib commented Oct 20, 2014

Author Name: Martin Dobias (@wonder-sk)


Giovanni Manghi wrote:

it seems anyway strange to me as I tested also on Windows (where anyone should have the same libraries) and cannot replicate the issue.

Unfortunately this is not that strange. It is quite common that errors in multi-threaded code appear just for some people, while working flawlessly for others.

@qgib
Copy link
Contributor Author

qgib commented Oct 20, 2014

Author Name: Saber Razmjooei (@saberraz)


It works fine in both WGS84 and 4269.

@qgib
Copy link
Contributor Author

qgib commented Nov 22, 2014

Author Name: Giovanni Manghi (@gioman)


still true?

@qgib
Copy link
Contributor Author

qgib commented Nov 22, 2014

Author Name: Anita Graser (@anitagraser)


Still true for me (Win8 OSGeo4W nightly 64bit).

@qgib
Copy link
Contributor Author

qgib commented May 10, 2015

Author Name: Giovanni Manghi (@gioman)


  • status_id was changed from Feedback to Open

@qgib
Copy link
Contributor Author

qgib commented May 11, 2015

Author Name: Anita Graser (@anitagraser)


Still true for 2.8.1 (Win8 OSGeo4W 64bit).

@qgib
Copy link
Contributor Author

qgib commented Oct 11, 2015

Author Name: Anita Graser (@anitagraser)


Still true for 2.11 today.


  • fixed_version_id was configured as Future Release - High Priority

@qgib
Copy link
Contributor Author

qgib commented Jan 23, 2016

Author Name: Martin Dobias (@wonder-sk)


As far as I can tell from my tests, this problem was caused by a bug in proj.4 library: OSGeo/PROJ#226

It has been fixed in proj 4.9.2 (released Sep 2015) which is now also available in osgeo4w (since end of Nov 2015). Could you please test again with the latest proj4 version to see if the problem is gone?


  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented Jan 23, 2016

Author Name: Anita Graser (@anitagraser)


Unfortunately still around ... even with the new proj ..

!projissues.PNG!

Please put back to "open".


  • 9494 was configured as projissues.PNG

@qgib
Copy link
Contributor Author

qgib commented Mar 4, 2016

Author Name: Anita Graser (@anitagraser)


@martin Can you please change the status back to open? Thanks!

@qgib
Copy link
Contributor Author

qgib commented Mar 4, 2016

Author Name: Martin Dobias (@wonder-sk)


Maybe we can have a look at it in Girona...


  • status_id was changed from Feedback to Open

@qgib
Copy link
Contributor Author

qgib commented Jan 8, 2017

Author Name: Giovanni Manghi (@gioman)


is there any update on this issue?


  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented Jan 9, 2017

Author Name: Anita Graser (@anitagraser)


Still same error unfortunately. Tested with latest 2.19 in OSGeo4W - so not latest master

!glitch219.PNG!


  • 10653 was configured as glitch219.PNG

@qgib
Copy link
Contributor Author

qgib commented Jan 10, 2017

Author Name: Jürgen Fischer (@jef-n)


Anita Graser wrote:

so not latest master

not even master - qgis-dev is from (removed) master_2. qgis-rel-dev should be more up to date (branched off from master_2 on release of 2.18)

@qgib
Copy link
Contributor Author

qgib commented Jan 10, 2017

Author Name: Giovanni Manghi (@gioman)


Jürgen Fischer wrote:

Anita Graser wrote:

so not latest master

not even master - qgis-dev is from (removed) master_2. qgis-rel-dev should be more up to date (branched off from master_2 on release of 2.18)

There will ever be a master/qgis3 package on osgeo4w? Just a practical question: I do/did most of master testing on Windows because it was very practical, if there will be no more master on osgeo4w I will have to review my strategy and compile daily on Linux.


  • status_id was changed from Feedback to Open

@qgib
Copy link
Contributor Author

qgib commented Jan 10, 2017

Author Name: Jürgen Fischer (@jef-n)


Giovanni Manghi wrote:

There will ever be a master/qgis3 package on osgeo4w?

sure.

@qgib
Copy link
Contributor Author

qgib commented Jan 10, 2017

Author Name: Anita Graser (@anitagraser)


Jürgen Fischer wrote:

qgis-rel-dev should be more up to date (branched off from master_2 on release of 2.18)

Ok, I'll try with qgis-rel-dev

@qgib
Copy link
Contributor Author

qgib commented Jan 10, 2017

Author Name: Anita Graser (@anitagraser)


Same issue in qgis-rel-dev

@qgib
Copy link
Contributor Author

qgib commented Mar 6, 2017

Author Name: Giovanni Manghi (@gioman)


Anita Graser wrote:

Same issue in qgis-rel-dev

what about the (qgis3) master? any change?


  • version was changed from master to 2.18.4
  • status_id was changed from Open to Feedback
  • priority_id was changed from High to Normal
  • fixed_version_id removed Future Release - High Priority

@qgib
Copy link
Contributor Author

qgib commented Mar 7, 2017

Author Name: Anita Graser (@anitagraser)


Still same here with 2.99 from OSGeo4W.

@qgib
Copy link
Contributor Author

qgib commented Mar 7, 2017

Author Name: Giovanni Manghi (@gioman)


  • fixed_version_id was configured as Version 3.0
  • status_id was changed from Feedback to Open
  • version was changed from 2.18.4 to master

@qgib
Copy link
Contributor Author

qgib commented Apr 30, 2017

Author Name: Giovanni Manghi (@gioman)


  • regression was configured as 0
  • easy_fix was configured as 0

@qgib
Copy link
Contributor Author

qgib commented May 17, 2017

Author Name: Nyall Dawson (@nyalldawson)


Anita - please test the next nightly 3.0 release as this is likely fixed now.


  • status_id was changed from Open to Feedback
  • description was changed from With active on-the-fly reprojection and parallel rendering, the map renders with big artifacts. I've tested the following project with both the 2.4 release and today's nightly:

https://github.com/FOSS4GAcademy/GST101FOSS4GLabs/tree/master/Module%204%20Lab/QGIS%202.2/Lab%204%20Data

Deactivating either OTF or parallel rendering fixes the problem as far as I can tell.

!glitch.png! to With active on-the-fly reprojection and parallel rendering, the map renders with big artifacts. I've tested the following project with both the 2.4 release and today's nightly:

https://github.com/FOSS4GAcademy/GST101FOSS4GLabs/tree/master/Module%204%20Lab/QGIS%202.2/Lab%204%20Data

Deactivating either OTF or parallel rendering fixes the problem as far as I can tell.

!glitch.png!

@qgib
Copy link
Contributor Author

qgib commented Nov 13, 2017

Author Name: Nyall Dawson (@nyalldawson)


Anita -can we close this? Should be fixed in master and recent 2.18

@qgib
Copy link
Contributor Author

qgib commented Nov 13, 2017

Author Name: Anita Graser (@anitagraser)


Looks good! Thanks Nyall!


  • status_id was changed from Feedback to Closed
  • resolution was changed from to fixed/implemented

@qgib qgib closed this as completed Nov 13, 2017
@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Map and Legend Related to map or legend rendering labels May 25, 2019
@qgib qgib added this to the Version 3.0 milestone May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Map and Legend Related to map or legend rendering
Projects
None yet
Development

No branches or pull requests

1 participant