Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

通过环境变量支持自定义service name #293

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

williamfzc
Copy link
Contributor

@williamfzc williamfzc commented Aug 5, 2022

#199 #292

/assign @memoryliu
/approve

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #293 (bc5f609) into master (50b62f0) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #293      +/-   ##
==========================================
- Coverage   70.85%   70.76%   -0.10%     
==========================================
  Files          34       34              
  Lines        2035     2035              
==========================================
- Hits         1442     1440       -2     
- Misses        480      482       +2     
  Partials      113      113              
Flag Coverage Δ
e2e-1.16.x ?
e2e-1.17.x ?
e2e-1.18.x ?
unittest-1.16.x 70.66% <ø> (-0.20%) ⬇️
unittest-1.17.x 70.76% <ø> (+0.09%) ⬆️
unittest-1.18.x 70.66% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cover/instrument.go 20.83% <ø> (ø)
pkg/build/gomodules.go 89.18% <0.00%> (-5.41%) ⬇️

@CarlJi
Copy link
Collaborator

CarlJi commented Aug 5, 2022

Thanks for your contribution @williamfzc

I am thinking that it's better to provide some explanations for this enhancement. And here seems a proper place. Of course, you can submit another PR if you will.

Thanks again.

@CarlJi
Copy link
Collaborator

CarlJi commented Aug 5, 2022

/lgtm
/approve

@qiniu-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CarlJi, williamfzc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiniu-bot qiniu-bot merged commit fd3df3e into qiniu:master Aug 5, 2022
williamfzc added a commit to williamfzc/goc that referenced this pull request Aug 5, 2022
qiniu-bot added a commit that referenced this pull request Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants